<html>
<head><meta charset="utf-8"><title>I-prioritize #27970 Does getaddrinfo need to take the ENV l… · t-compiler/wg-prioritization/alerts · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/index.html">t-compiler/wg-prioritization/alerts</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html">I-prioritize #27970 Does getaddrinfo need to take the ENV l…</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="216474970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/216474970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#216474970">(Nov 12 2020 at 14:28)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="3111">@WG-prioritization/alerts</span> issue <a href="https://github.com/rust-lang/rust/issues/27970">#27970</a> has been requested for prioritization.</p>
<h1><a href="https://forge.rust-lang.org/compiler/prioritization/procedure.html#assign-priority-to-unprioritized-issues-with-i-prioritize-label">Procedure</a></h1>
<ul>
<li>Priority?</li>
<li>Regression?</li>
<li>Notify people/groups?</li>
<li>Needs <code>I-nominated</code>?</li>
</ul>



<a name="216475392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/216475392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Hameer Abbasi <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#216475392">(Nov 12 2020 at 14:32)</a>:</h4>
<p>Oh this one is tricky. On the one hand, multithreading unsoundness. On the other, back-compat. Is there a history of which one we prefer over the other?</p>



<a name="217121013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217121013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217121013">(Nov 18 2020 at 11:08)</a>:</h4>
<p>I'm not entirely sure about this one. This <a href="https://github.com/rust-lang/rust/issues/27970#issuecomment-264624978">comment</a> and this <a href="https://github.com/rust-lang/rust/issues/27970#issuecomment-572578962">comment</a> seems to imply (or perhaps I am misinterpreting) that this is unsafe <strong>but</strong> documented. </p>
<p>What should or could be done on a "T-libs" level or rather in the implementing crates? If the crate uses <code>localtime_r</code> bypasses the safeguard set by the Rust library (again, this is my understanding).</p>
<p>I am more inclined to maybe <code>I-nominate</code> this for a discussion</p>



<a name="217190422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217190422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217190422">(Nov 18 2020 at 20:14)</a>:</h4>
<p>bump, unprioritized</p>



<a name="217193744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217193744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217193744">(Nov 18 2020 at 20:40)</a>:</h4>
<p>I'm not even sure what to do with this one</p>



<a name="217194387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217194387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217194387">(Nov 18 2020 at 20:47)</a>:</h4>
<p>Afaict the unsafety is only caused when interacting with extern code, so the standard library on its own is sound</p>



<a name="217194533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217194533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217194533">(Nov 18 2020 at 20:48)</a>:</h4>
<p><span class="user-mention" data-user-id="216206">@lcnr</span> yep</p>



<a name="217194536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217194536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217194536">(Nov 18 2020 at 20:48)</a>:</h4>
<p>so unsure :)</p>



<a name="217194556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217194556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217194556">(Nov 18 2020 at 20:48)</a>:</h4>
<p>though it does seem like this happens at least somewhat frequently</p>



<a name="217194625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217194625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217194625">(Nov 18 2020 at 20:49)</a>:</h4>
<p>or much rather, there are unsound apis out there where the unsoundness is hard to trigger</p>



<a name="217194675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217194675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217194675">(Nov 18 2020 at 20:50)</a>:</h4>
<p>idk, let's just slap <code>P-medium</code> on it and hope it doesn't end up biting us?</p>



<a name="217197445"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2327970%20Does%20getaddrinfo%20need%20to%20take%20the%20ENV%20l%E2%80%A6/near/217197445" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2327970.20Does.20getaddrinfo.20need.20to.20take.20the.20ENV.20l.E2.80.A6.html#217197445">(Nov 18 2020 at 21:12)</a>:</h4>
<p>Issue <a href="https://github.com/rust-lang/rust/issues/27970">#27970</a>'s prioritization request has been removed.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>